Skip to content

Issue 334: 8.3 add comments to code - #348

Merged
pearcej merged 2 commits into
RunestoneInteractive:masterfrom
habibasorour:issue_334_comment
Aug 5, 2026
Merged

Issue 334: 8.3 add comments to code#348
pearcej merged 2 commits into
RunestoneInteractive:masterfrom
habibasorour:issue_334_comment

Conversation

@habibasorour

Copy link
Copy Markdown
Contributor

Description

Add comments to code blocks

Issue Fix

fixes #334

Screenshot

image

Tested

Local Build

@DieuMerci225

Copy link
Copy Markdown

The fix looks good. You can tag me as a reviewer

@pearcej

pearcej commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@habibasorour @DieuMerci225 This code does not seem to work. Adding comments before fixing it seems silly. How was this tested?

image

@habibasorour

Copy link
Copy Markdown
Contributor Author

@pearcej, can you try this version of the code in your local build that can run Java? I think I figured out what the problem is but I can not test it from my end.

@pearcej

pearcej commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@habibasorour @DieuMerci225 Was this tested in Runestone or just locally?

@habibasorour

habibasorour commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@pearcej the code itself was tested in Runestone to make sure the comments did not cause an issue while running. Otherwise, the formatting and seeing the <listing> tags were tested locally.

@pearcej

pearcej commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@habibasorour @DieuMerci225 The Java needs to be tested on Runestone. Please alert me ONLY when this is done.

@habibasorour

Copy link
Copy Markdown
Contributor Author

@pearcej the code runs fine in Runestone as shown below

image

@pearcej
pearcej marked this pull request as ready for review August 5, 2026 13:52
@pearcej
pearcej merged commit 363513f into RunestoneInteractive:master Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8.3: Add comments

3 participants