Run test suite in emulator as part of Android build workflow#920
Draft
ribbons wants to merge 2 commits into
Draft
Run test suite in emulator as part of Android build workflow#920ribbons wants to merge 2 commits into
ribbons wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tridge - inspired by our initial exchange in #901 here is a proof of concept of running the test suite within the Android emulator under Termux as part of the Android build workflow you set up previously. The script can also be run locally if a build targeting Android has been done and an Android emulator is running (I've made the script skip installing Termux or Python if they are already installed to make it fairly quick to keep running the tests).
I need to have a few more passes through the script to make things cleaner and tidier, add some more checks, write a decent commit message etc but I'm happy to chip away at all that stuff over the next few days if this looks like the kind of approach you'd be in favour of?
As naming things is always difficult, do you think
android-run-testsis a logical / consistent name for the script and is undersupporta sensible place for it (very happy to change if you have strong feelings otherwise)?