ci: clean up workflow shellcheck nits#919
Merged
Merged
Conversation
actionlint (rhysd/actionlint) reported a handful of shellcheck-class issues
across the GitHub Actions workflows. All are 1-line mechanical fixes:
* Replace legacy backticks in --rsync-bin=`pwd`/rsync with
--rsync-bin="$PWD/rsync" (SC2006 + SC2046; almalinux-8-build,
macos-build, ubuntu-22.04-build, ubuntu-build).
* Quote >>$GITHUB_PATH redirects as >>"$GITHUB_PATH"
(SC2086; coverage, macos-build, ubuntu-22.04-build, ubuntu-build).
After this commit `actionlint .github/workflows/*.yml` exits 0.
(Also cleaned up 6 editor backup *.yml~ files from the local working
tree; those weren't tracked -- *~ is gitignored -- so the cleanup is
local-only and not part of this commit.)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds .github/workflows/actionlint.yml which runs rhysd/actionlint over .github/workflows/*.yml on push and PR to master. Triggers only when something in .github/workflows/ (or the actionlint config) changes, so the rest of the platform matrix isn't billed when nothing here moves. The job downloads a pinned actionlint binary (1.7.12) via the upstream download script (which verifies a SHA256) -- no third-party Action dependency, matching the inline-install style of the existing ubuntu/macos/cygwin workflows. Bump the pinned version deliberately. actionlint catches a) GitHub Actions expression / type errors, b) unsupported runner images, c) missing secrets / inputs, and d) the embedded shellcheck class of issues in 'run:' scripts that the previous commit cleaned up. Keeping it in CI prevents regressions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actionlint (rhysd/actionlint) reported a handful of shellcheck-class issues across the GitHub Actions workflows. All are 1-line mechanical fixes:
pwd/rsync with --rsync-bin="$PWD/rsync" (SC2006 + SC2046; almalinux-8-build, macos-build, ubuntu-22.04-build, ubuntu-build).After this commit
actionlint .github/workflows/*.ymlexits 0.(Also cleaned up 6 editor backup *.yml~ files from the local working tree; those weren't tracked -- *~ is gitignored -- so the cleanup is local-only and not part of this commit.)