fix fleettest for recent changes - #1096
Merged
Merged
Conversation
match CI for IDN tests
RsyncProject#1069 replaced daemon-max-alloc-zero with max-alloc-zero, which no longer needs the old static client, but the per-box expect_skip_extra entries still named the old test, so runtests refused the skip list ("no such test") on every Linux target. Drop those entries. Pin python3.9 on the cygwin target to match the workflow, which installs only python39: the box's default python3 (3.12) has a working AF_UNIX socketpair, so daemon-stdin-local-socket ran where cygwin.txt expects a skip. Note that python39 must be 3.9.25+ for os.getxattr, which the xattr tests need to run as they do in CI.
…copystat runtests.py exports POSIXLY_CORRECT=1 to every test, and bash before 5.1 disables process substitution in POSIX mode, so pseudo-paths, pseudo-paths-daemon and read-batch-pipe silently skipped on bash 4.4/5.0 hosts (Ubuntu 18.04/20.04, AlmaLinux 8). Strip the variable from bash's environment: the tests require bash precisely for that syntax. That was also why they skipped in the AlmaLinux 8 CI container, so its skip list (which held only those three) goes away along with the workflow's reference to it. The macOS list keeps them: there they skip as Linux-only. malicious-sender-delete-scope copies the source tree with symlinks=True. Cygwin's python 3.9.25 gained os.listxattr, and copystat() on a fresh symlink then fails with EACCES, although the link itself was created. Ignore copytree errors that are only about symlink pairs; anything else still raises.
steadytao
approved these changes
Sep 20, 2026
steadytao
left a comment
steadytao
left a comment
Member
There was a problem hiding this comment.
COVERAGE.md just needs a small update; pushing shortly. Otherwise, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge of the IDN PR plus a few other recent changes broke fleettest. This fixes things up again