Build error on Solaris 10 / SPARC

[idgn23]

Introduced with 3.5.0. 3.4.1 was building fine.

==> Running make in work/solaris10-sparc/build-isa-sparcv8plus/rsync-3.5.1 cd work/solaris10-sparc/build-isa-sparcv8plus/rsync-3.5.1 && /usr/bin/env -i HOME="/home/ihsan" PATH="/home/ihsan/opencsw/.buildsys/v2/gar/bin/sos12-wrappers:/home/ihsan/opencsw/rsync/trunk/work/solaris10-sparc/install-isa-sparcv8plus/opt/csw/bin:/home/ihsan/opencsw/rsync/trunk/work/solaris10-sparc/install-isa-sparcv8plus/opt/csw/bin:/home/ihsan/opencsw/rsync/trunk/work/solaris10-sparc/install-isa-sparcv8plus/opt/csw/sbin:/home/ihsan/opencsw/rsync/trunk/work/solaris10-sparc/install-isa-sparcv8plus/opt/csw/sbin:/opt/csw/bin:/opt/csw/bin:/opt/csw/sbin:/opt/csw/sbin:/opt/SUNWspro/bin:/home/ihsan/opencsw/.buildsys/v2/gar/bin:/usr/bin:/usr/sbin:/usr/java/bin:/usr/ccs/bin:/usr/openwin/bin" LC_ALL="C" prefix="/opt/csw" exec_prefix="/opt/csw" bindir="/opt/csw/bin" sbindir="/opt/csw/sbin" libexecdir="/opt/csw/libexec" datadir="/opt/csw/share" sysconfdir="/etc/opt/csw" sharedstatedir="/opt/csw/share" localstatedir="/var/opt/csw" libdir="/opt/csw/lib" infodir="/opt/csw/share/info" lispdir="/opt/csw/share/emacs/site-lisp" includedir="/opt/csw/include" mandir="/opt/csw/share/man" docdir="/opt/csw/share/doc" sourcedir="/opt/csw/src" CPPFLAGS="-I/opt/csw/include" CFLAGS="-xO3 -m32 -xarch=sparc" CXXFLAGS="-xO3 -m32 -xarch=sparc" LDFLAGS="-m32 -xarch=sparc -L/opt/csw/lib" FFLAGS="-xO3 -m32 -xarch=sparc" FCFLAGS="-xO3 -m32 -xarch=sparc" F77="/opt/SUNWspro/bin/f77" FC="/opt/SUNWspro/bin/f95" ASFLAGS="" OPTFLAGS="-xO3 -m32 -xarch=sparc" CC="/opt/SUNWspro/bin/cc" CXX="/opt/SUNWspro/bin/CC" CC_HOME="/opt/SUNWspro" CC_VERSION="Sun C 5.9 SunOS_sparc Patch 124867-16 2010/08/11" CXX_VERSION="Sun C++ 5.9 SunOS_sparc Patch 124863-30 2012/07/11" GARCH="sparc" GAROSREL="5.10" GARPACKAGE="trunk" LD_OPTIONS="-R/opt/csw/lib/\$ISALIST -R/opt/csw/lib -M /home/ihsan/opencsw/.buildsys/v2/gar/lib/map.solaris10 -B direct -z ignore" MAKEFLAGS= gmake -I/home/ihsan/opencsw/.buildsys/v2 -C . gmake: Entering directory '/home/ihsan/opencsw/rsync/trunk/work/solaris10-sparc/build-isa-sparcv8plus/rsync-3.5.1' gawk -f ./daemon-parm.awk ./daemon-parm.txt gawk -f ./mkproto.awk ./*.c ./lib/compat.c daemon-parm.h /opt/SUNWspro/bin/cc -I. -I. -I./zlib -xO3 -m32 -xarch=sparc -DHAVE_CONFIG_H -I/opt/csw/include -c flist.c -o flist.o /opt/SUNWspro/bin/cc -I. -I. -I./zlib -xO3 -m32 -xarch=sparc -DHAVE_CONFIG_H -I/opt/csw/include -c rsync.c -o rsync.o "rsync.c", line 570: undefined symbol: O_CLOEXEC "rsync.c", line 595: undefined symbol: O_CLOEXEC "rsync.c", line 619: undefined symbol: O_CLOEXEC cc: acomp failed for rsync.c gmake: *** [Makefile:76: rsync.o] Error 2 gmake: Leaving directory '/home/ihsan/opencsw/rsync/trunk/work/solaris10-sparc/build-isa-sparcv8plus/rsync-3.5.1' gmake[1]: *** [/home/ihsan/opencsw/.buildsys/v2/gar//gar.lib.mk:908: build-work/solaris10-sparc/build-isa-sparcv8plus/rsync-3.5.1/Makefile] Error 2 gmake[1]: Leaving directory '/home/ihsan/opencsw/rsync/trunk' gmake: *** [gar/gar.mk:201: build-isa-sparcv8plus] Error 2

[steadytao]

Confirmed. This is a 3.5.0 regression from the path-hardening work as rsync.c now uses O_CLOEXEC in three places without a portability fallback. We already have the correct fallback in syscall.c but it is scoped inside one function and therefore does not apply here.

I will move the fallback into a shared header and add coverage for platforms where O_CLOEXEC is unavailable.

It is unfortunate this only surfaced after 3.5.1 as the regression was introduced with 3.5.0 and this was exactly the kind of downstream platform testing I was hoping to get from the mailing-list call before the regression release. Still, thank you for reporting it now.