Repository navigation
Conversation
RowDaBoat
marked this pull request as ready for review
September 7, 2026 22:13
RowDaBoat
force-pushed
the
benchmark-update
branch
from
September 7, 2026 23:43
0af3c01 to
3bccd5b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
The previous comparison labeled any median change above a fixed 5% as significant, while its CSV retained only one median per benchmark. A same-source CI comparison reproduced false 5.1-5.5% regressions, and a local same-binary run produced false 13-18% improvements in churn rows.
The first revision preserved inner samples, but an optimization trial exposed a second issue: samples from one process are correlated and cannot stand in for independent runs. Two process medians moved by several percent while the pooled samples still produced directional verdicts.
Changes
Validation
testssuite passes, including the benchmark regression tests.tests/manycomponents.nimpasses with-d:ArchetypeWords=2.This branch is the required baseline for subsequent optimization work.