[Fix] Integration guidance and old links still point to Settings > Integrations - #3166
Merged
Merged
Conversation
Contributor
|
1 issue outstanding. See task
Reviewed fee9216 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 23, 2026 12:48
…age-references-04a2fr0jyxca2 # Conflicts: # apps/docs/integrations/index.mdx # apps/web/src/components/settings/IntegrationToolApprovalsExperimentalSetting.client.test.tsx # apps/web/src/components/settings/IntegrationToolApprovalsExperimentalSetting.tsx
| * Not a catalog integration: the Brain is infrastructure, not something a | ||
| * user connects in Settings. A deployment that supplies | ||
| * user connects on the Integrations page. A deployment that supplies | ||
| * R_BRAIN_OPENROUTER_API_KEY or R_BRAIN_OPENAI_API_KEY has a Brain; |
Contributor
There was a problem hiding this comment.
This comment still says an R_BRAIN_* key alone means the deployment “has a Brain” and that all behavior follows from that one signal. A stored Settings > Memory choice now overrides the legacy key fallback (isBrainEnabled()), so a deployment can have a provider key while Memory is disabled. Please update this comment to describe Memory as the activation control and the key as legacy fallback/provider configuration; it also should not direct readers to the Integrations page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No linked issue. This is a follow-up to #2937, which moved Integrations out of Settings to a top-level
/integrationspage.Why this PR exists
#2937 moved the page and updated the URL builders, but agent prompts, tool descriptions, error messages, UI copy, and docs still sent people to "Settings → Integrations". The old
/settings/integrationsURL also started returning 404, even though links to it already sit in chat messages, emails, transcripts, and OAuthredirectTovalues created before the move.What changed
Agent replies, error messages, UI hints, and docs now send people to the top-level Integrations page instead of a Settings section that no longer exists. Old
/settings/integrationslinks open the Integrations page instead of a 404. Slack and GitHub setup guidance now points to the Settings pages where those providers are actually configured. The only behavior change beyond copy is the new redirect. Changes by category:Route. The Integrations page is served at
/integrationsbyapps/web/src/app/(authenticated)/integrations/page.tsx. No legacy redirect existed, so/settings/integrationsfell through to the authenticated catch-all and 404'd. This PR addssettings/integrations/page.tsx, reusing theLegacySettingsRedirectPagethat/settings/automationsalready uses. Old links now land on/integrationsand keep their query string and hash, such as?highlight=…,?service=…, or?mcp=connected.Agent and session prompts, tool text, and skills
fast-agent-prompt.ts):connect_integrationguidance now names "the secure form on the Integrations page".authorizeUrlandsettingsUrllinks exactly".add_remote_mcppreviously called itssettingsUrl"the existing Settings link". It now says the link goes to the Integrations page for a shared server, or Personal settings for a private one.connect_integrationnow names "the existing secure form on the Integrations page".Integration settingslink label stays, because a private server's link resolves to Personal settings.mcp-self-setup/catalog.ts): built-ins now useIntegrations > X. Slack now usesSettings > Communications > Slackand GitHubSettings > Source Control > GitHub, because neither is configured on the Integrations page. GitHub previously pointed at an Environments sub-section that no longer exists.get_about_meintegrations guide (integration-setup.ts):feature-demo: the ElevenLabs voice-over note.zero.add-integrationskill: its catalog description, its custom MCP recommendation, and the setup-guide wording it prescribes for new integrations.Error and unavailable messages
add_remote_mcpname and URL conflict: "Review them on the Integrations page or in Personal settings."UI copy (apps/web)
add_remote_mcpsetup results: now "needs manual setup", previously "needs setup in Settings". The link can go to either page.Docs (apps/docs)
Integrations > Xfor nested paths. They cover the integration guides and overview, integration keys, HTTP integrations, custom MCP servers, personal settings, voice, environment variables, and cookbook recipes.Comments and tests. Code comments that named the old path are updated. Tests that asserted the old strings are updated. New tests cover the legacy redirect, the worker integrations guide, the setup catalog locations, and the
add_remote_mcptool-presentation label.Deliberately not changed
settingsUrlresult field and theSETTINGS_PATHS.integrationsconstant. Both already resolve to/integrations./settingsfallback in the MCP OAuth initiate and callback routes, which predates the move.CHANGELOG.mdhistory.How it was tested
@roomote/types,@roomote/worker,@roomote/sdk,@roomote/api, and@roomote/cloud-agents, plus focused@roomote/webserver and client suites for the changed surfaces. One@roomote/cloud-agentstest (opencode-runtimeplugin seeding) fails in the dev sandbox. It also fails on unmodifieddevelopand is unrelated to this change.pnpm lint,pnpm check-types,pnpm knip, andpnpm --filter @roomote/docs check./settings/integrations?highlight=sentry-mcpredirected to/integrations?highlight=sentry-mcp(screenshots below).Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset.changeset/integrations-page-references.md(patch).Screenshots