[Feat] Agents screen their own diff for risky hunks before they ship - #3141
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
get_diff_risk_hintstool for coding tasks. During its self-review, before it pushes or opens a pull request, the agent calls it once. It runs the same decision-model pre-screen pull request reviews use (#3119, #3130) on the branch's diff and returns up to three changed hunks most likely to contain a defect, each with the kind of issue suspected. The agent re-reads those hunks and fixes what the code confirms.The point is catching an issue one review round earlier: fixed before the push, instead of found by the reviewer, picked up by the agent, and fixed in another push.
Why this shape
It replaces the completion check removed in #3139 and avoids what made that fragile:
screenReviewHunksand wraps it with author-facing wording; the review path is unchanged.implement-changesself-review step.How
origin/HEADmerge-base, including uncommitted and untracked files (what the pull request will show).POST /api/mcp/tasks/runs/:runId/diff_risk_hints(run token, run must match) screens it with the task title; the judgment model key stays on the API.available: falsewhen there is no hosted judgment model.Measuring it
Worth checking after a week on nightly: the share of agent pull requests whose first review finds issues, before and after.
Validation
pnpm lint:fast,pnpm check-types:fast,pnpm knip; cloud-agents workflows and worker MCP suites.