[Fix] Stop Fast from adding unrequested no-PR constraints to task briefs - #3110
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user asks a Session for a code change without saying anything about delivery, the Fast orchestrator sometimes appends its own "Do not create a PR or commit unless asked" constraint to the delegated task brief. The coding task obeys, finishes with local-only changes, and the user has to come back and ask for a PR separately. Nothing in the Fast prompt told the orchestrator what delivery policy to carry, so it invented one, overriding the standard workflow's default draft-PR delivery.
This adds one orchestration rule: carry the user's delivery instruction into the task brief only when they actually gave one, and otherwise leave delivery to the task's default workflow. It explicitly forbids inferring a no-commit/no-push/no-PR constraint from a detailed spec, listed constraints, requested tests, or a request to report results.
Changes
packages/cloud-agents/src/server/fast-agent/fast-agent-prompt.ts: new Orchestration Policy bullet after thelaunch_taskdelegation rule.packages/cloud-agents/src/server/fast-agent/__tests__/fast-agent-prompt.test.ts: prompt-assembly assertion for the new rule.Validation
vitest run src/server/fast-agent/__tests__/fast-agent-prompt.test.tsin@roomote/cloud-agents: 125 passed.oxfmton both files.