[Improve] Add enabled integrations summary to daily instance report - #3107
Merged
brunobergher merged 5 commits intoSep 22, 2026
Merged
brunobergher merged 5 commits into
brunobergher merged 5 commits into
Conversation
Contributor
|
No code issues found. See task
Reviewed 03ec8f |
brunobergher
marked this pull request as ready for review
September 22, 2026 10:51
brunobergher
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 22, 2026 10:51
brunobergher
approved these changes
Sep 22, 2026
Contributor
Author
|
All outstanding review findings are fixed; the MCP connection ownership one landed in commit 03ec8fd2:
Validation: the instance-report test file passes 20/20, format, lint, |
…rom integrations summary
brunobergher
deleted the
feature/instance-report-enabled-integrations-3fkivqdmgv6us
branch
September 22, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The daily anonymous instance report now includes an
integrationssummary alongside the existingautomationssummary. It reports a flat{ enabled, enabledNames }payload whereenabledis the total enabled integration count andenabledNamesone list of enabled integration names: built-in MCP integrations keep their safe catalog ids, while each enabled custom MCP or personal server appears as a deterministiccustom-integration-Nstub and each live API-key (service credential) integration asapi-key-integration-N, numbered from sorted underlying ids. Enabled MCP ids come from an extracted helper that keeps deployment connections while dropping user-scoped connections of soft-deleted users; custom integrations come from the enabled custom/personal server rows via a second helper, so servers usingnone,static_headers, or stdio are counted too, and personal servers of soft-deleted owners are excluded like the runtime lookup does. API-key integrations reuse the canonical live grant predicate.custom:<id>connection entries are skipped so OAuth-based custom servers are never double-counted. Labels and origins never leave the instance.Why this change was made
The report already covered enabled automations but not enabled integrations. Integration names are owner-authored and may be sensitive, so custom and API-key entries must be anonymized before they reach the Ping service or PostHog, while built-in catalog names are safe to emit.
Impact
The anonymous daily ping gains an
integrationsfield with an accurate enabled total and enabled names without ever leaking user-authored integration labels, origins, or any other customer data, and it stays accurate for non-OAuth custom servers as well as for items whose owners were soft-deleted.Validation
Targeted test file passes 20/20 including regression coverage for each review fix; root lint and full workspace typecheck pass; pre-push hooks green. The one full-suite failure observed locally is a preexisting shared-database
seed-demo-data.test.tsflake that passes standalone and is untouched by this diff.