Skip to content

[Fix] Recover repository selection when editing an environment - #3098

Merged
daniel-lxs merged 2 commits into
developfrom
fix/edit-environment-repository-load-recovery-3c3gchdzdmyy0
Sep 22, 2026
Merged

daniel-lxs merged 2 commits into
developfrom
fix/edit-environment-repository-load-recovery-3c3gchdzdmyy0

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

Editing an existing environment now distinguishes a failed initial repository read from an empty list. A compact, announced error and Retry action replace the misleading missing-repository hint, and Start Agent stays disabled until the initial read succeeds. Cached repository choices and direct YAML editing remain available.

Retry restores repository choices without losing the typed change request. The recovery message uses the existing button styles and fits inline within the editor card on desktop and mobile.

Validation on the updated head covered current-develop reproduction, an actual failed repository query, keyboard Retry, recovered selections, retained draft text, cached choices during a background failure, and successful task creation with the selected repository and request in the persisted payload. A successfully empty repository list still permits repository-free editing. All 17 focused create/edit tests, lint, typechecks, formatting, and Knip passed.

The controlled failure was confined to a disposable local database and exercised the real application query and recovery path. Desktop and 390×844 mobile layouts were inspected. Task creation was verified through the queued state; worker execution and a live source-control-provider outage were outside this UI change's scope.

Screenshots from the original revision

These captures show the recovery flow at c0b3629e, before the compact error-row refinement in 0102a923d. The current error state uses an inline message and Retry button instead of the larger bordered panel shown below.

Desktop repository-load error with Retry

Mobile repository-load error with Retry

Mobile repository selection after Retry recovery

@roomote-community

roomote-community Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

Reviewed 0102a92

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 22, 2026 06:43

@daniel-lxs daniel-lxs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the initial repository-load failure against current develop and recovery on this exact head. Keyboard Retry restores repository choices while preserving typed instructions; cached selections survive a failed background read. Successful task creation persists the selected repository and request. Desktop/mobile error layout, valid empty-list behavior, direct YAML access, 17 focused tests, lint, typechecks, formatting, and Knip passed.

@daniel-lxs
daniel-lxs merged commit d91283b into develop Sep 22, 2026
17 checks passed
@daniel-lxs
daniel-lxs deleted the fix/edit-environment-repository-load-recovery-3c3gchdzdmyy0 branch September 22, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant