[Fix] Recover repository selection when editing an environment - #3098
Merged
daniel-lxs merged 2 commits intoSep 22, 2026
Merged
daniel-lxs merged 2 commits into
daniel-lxs merged 2 commits into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 22, 2026 06:43
daniel-lxs
approved these changes
Sep 22, 2026
daniel-lxs
left a comment
Member
There was a problem hiding this comment.
Verified the initial repository-load failure against current develop and recovery on this exact head. Keyboard Retry restores repository choices while preserving typed instructions; cached selections survive a failed background read. Successful task creation persists the selected repository and request. Desktop/mobile error layout, valid empty-list behavior, direct YAML access, 17 focused tests, lint, typechecks, formatting, and Knip passed.
daniel-lxs
deleted the
fix/edit-environment-repository-load-recovery-3c3gchdzdmyy0
branch
September 22, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing an existing environment now distinguishes a failed initial repository read from an empty list. A compact, announced error and Retry action replace the misleading missing-repository hint, and Start Agent stays disabled until the initial read succeeds. Cached repository choices and direct YAML editing remain available.
Retry restores repository choices without losing the typed change request. The recovery message uses the existing button styles and fits inline within the editor card on desktop and mobile.
Validation on the updated head covered current-develop reproduction, an actual failed repository query, keyboard Retry, recovered selections, retained draft text, cached choices during a background failure, and successful task creation with the selected repository and request in the persisted payload. A successfully empty repository list still permits repository-free editing. All 17 focused create/edit tests, lint, typechecks, formatting, and Knip passed.
The controlled failure was confined to a disposable local database and exercised the real application query and recovery path. Desktop and 390×844 mobile layouts were inspected. Task creation was verified through the queued state; worker execution and a live source-control-provider outage were outside this UI change's scope.
Screenshots from the original revision
These captures show the recovery flow at
c0b3629e, before the compact error-row refinement in0102a923d. The current error state uses an inline message and Retry button instead of the larger bordered panel shown below.