[Fix] Session cards trigger an accessibility audit violation on actor avatars - #3095
Merged
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 22, 2026 06:11
daniel-lxs
approved these changes
Sep 22, 2026
daniel-lxs
left a comment
Member
There was a problem hiding this comment.
Verified the exact head against current develop using loaded-image, missing-image fallback, automation-owned, and current-viewer avatar states. Redundant avatar labels disappear from the browser accessibility tree while adjacent actor text, unread indicators, and card controls remain available. Desktop/mobile card geometry is unchanged and keyboard navigation still works. All 23 focused SessionCard/Avatar tests, web typecheck, scoped lint, and formatting passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Not applicable: this is an internally authorized accessibility fix.
Why this PR exists
What changed
Session cards now keep actor avatars decorative when the adjacent actor text already names the session owner. User avatars use the existing empty-alt convention, and automation avatars are hidden from the accessibility tree instead of exposing an invalid label on a generic element. The visible avatar layout and actor text are unchanged, while screen readers receive one actor announcement from the existing card metadata.
How it was tested
@roomote/webclient suite passes 329 files and 3007 tests.@roomote/webtypecheck, lint, and format checks pass;pnpm lint:pre-pushpasses oxlint, residual lint, 27-package fast typechecks, and Knip./sessionsreproduction dropped the seriousaria-prohibited-attrviolation on 7 avatar nodes; targeted card axe checks show no instance of that rule, and the accessibility tree keeps the actor text without an avatar announcement.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetFollow-up validation
Fresh authenticated product checks on unchanged head
9553899fcompared current develop with this PR using loaded-image, missing-image fallback, automation-owned, and current-viewer avatar cards. The avatar labels disappear from the accessibility tree while the adjacent actor text, unread indicator, card links, and action controls remain available. Desktop and 390×844 mobile layouts were inspected; all four card dimensions matched the baseline and keyboard activation still opened the correct session.All 23 focused SessionCard and Avatar tests, web fast typechecking, scoped lint, and formatting passed. This follow-up inspected rendered DOM and browser accessibility semantics; it does not claim a new full-page axe audit or screen-reader audio test.
Screenshots
Original author captures, recovered and visually inspected as references alongside the fresh local validation above. These are not captures of the additional follow-up fixtures.