Skip to content

[Fix] Show missing environment recovery in Custom Automations - #3092

Merged
daniel-lxs merged 1 commit into
developfrom
fix/custom-automation-environment-validation
Sep 22, 2026
Merged

daniel-lxs merged 1 commit into
developfrom
fix/custom-automation-environment-validation

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

Custom Automation creation and editing now keeps a missing Preferred environment error beside the field instead of showing only a toast. The select receives the existing accessible invalid-field treatment, focus and scroll to the field on submit, and clears the error as soon as an environment is selected.

Why this change was made

Submitting a valid name and prompt without an environment previously left the dialog unchanged except for a transient Choose an environment. toast, making the required recovery control easy to miss. The change follows the existing Name, Prompt, and schedule validation pattern without changing valid payloads or destination behavior.

Impact

People can see exactly which required field needs attention, keyboard and assistive-technology users receive an associated error description, and correcting the selection proceeds through the existing create/edit flow. Focused client coverage verifies the blocked submit, accessibility state, correction clearing, and unchanged valid environment payload.

Authenticated local proof covered the genuine desktop and mobile dialog states, creation and edit persistence with the seeded Roomote Demo Environment, and cleanup of the disposable automation. Visual proof:

Desktop missing environment validation

Desktop corrected environment

Desktop persisted edit

Mobile persisted edit

Mobile missing environment validation

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 22, 2026 05:52
@roomote-community

roomote-community Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 9a9b976

@daniel-lxs daniel-lxs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified field focus and associated validation, immediate error clearing, draft preservation, clean dialog reopening, and create/edit persistence through a browser reload on the exact head. Desktop/mobile inspection, 64 focused tests, web typecheck, scoped lint, and formatting passed.

@daniel-lxs
daniel-lxs merged commit fe05588 into develop Sep 22, 2026
17 checks passed
@daniel-lxs
daniel-lxs deleted the fix/custom-automation-environment-validation branch September 22, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant