[Fix] Show missing environment recovery in Custom Automations - #3092
Merged
Merged
Conversation
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 22, 2026 05:52
Contributor
daniel-lxs
approved these changes
Sep 22, 2026
daniel-lxs
left a comment
Member
There was a problem hiding this comment.
Verified field focus and associated validation, immediate error clearing, draft preservation, clean dialog reopening, and create/edit persistence through a browser reload on the exact head. Desktop/mobile inspection, 64 focused tests, web typecheck, scoped lint, and formatting passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Custom Automation creation and editing now keeps a missing Preferred environment error beside the field instead of showing only a toast. The select receives the existing accessible invalid-field treatment, focus and scroll to the field on submit, and clears the error as soon as an environment is selected.
Why this change was made
Submitting a valid name and prompt without an environment previously left the dialog unchanged except for a transient
Choose an environment.toast, making the required recovery control easy to miss. The change follows the existing Name, Prompt, and schedule validation pattern without changing valid payloads or destination behavior.Impact
People can see exactly which required field needs attention, keyboard and assistive-technology users receive an associated error description, and correcting the selection proceeds through the existing create/edit flow. Focused client coverage verifies the blocked submit, accessibility state, correction clearing, and unchanged valid environment payload.
Authenticated local proof covered the genuine desktop and mobile dialog states, creation and edit persistence with the seeded Roomote Demo Environment, and cleanup of the disposable automation. Visual proof: