[Improve] Give secure integration approvals more room - #3061
Draft
roomote-roomote[bot] wants to merge 3 commits into
Draft
roomote-roomote[bot] wants to merge 3 commits into
roomote-roomote[bot] wants to merge 3 commits into
Conversation
Contributor
|
No new code issues found. See task
Reviewed fb07763 |
Contributor
Author
|
Resolved both outstanding review findings in commit
Validation: 31 affected tests pass; web lint and typecheck pass; pre-push oxlint, residual lint, fast typecheck, and Knip gates pass. GitHub Test, Lint, Type Check, Knip, and Roomote code review checks are green on |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lgsize to2xl.prepare_integration_keycard,#integrationsroute, password masking, owner-only approval API, visibility choice, secure submission, and continuation behavior unchanged.request_user_inputand task environment-variable surfaces.Why this change was made
API keys belong in the dedicated secure integration approval flow, not in structured conversation answers or task environment-variable UI. The approval form now has the requested spacious treatment on the real product path without widening the scope to unrelated inputs.
Impact
Session owners who follow a secure integration approval link now see the existing form in a 2xl dialog with more horizontal room. No key is routed through chat, transcript state, or model tool arguments, and no task input behavior changes.
The real-route proof used a temporary owner-bound Session, a pending approval containing only nonsecret metadata for
https://api.example.com, and a canonical completedprepare_integration_keyresult. The form loaded through/api/sessions/:sessionId/secrets; no key value was entered or stored, and the fixture was removed after capture.Screenshots
Before
After