Fix controller duplication in TimeNodes.merge()#964
Closed
karlhillx wants to merge 1 commit into
Closed
Conversation
karlhillx
force-pushed
the
fix/controller-duplicate-merge
branch
from
e6447b4 to
aa01208
Compare
Remove duplicate _controllers append that caused each controller to be called twice per simulation time node. Closes RocketPy-Team#959
Gui-FernandesBR
force-pushed
the
fix/controller-duplicate-merge
branch
from
aa01208 to
8e696c6
Compare
Member
|
the only modified file is a test file. The PR description is not aligned with the PR changes. I'm closing this PR since it doesn't really solve a problem or improve anything. Please feel free to improve yout branch and propose a new PR. Remind to open PRs always heading to the 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #959
Removed duplicate _controllers += node._controllers in
TimeNodes.merge() that caused each controller to be called
twice per time node during simulation.
Added unit test verifying merge accumulation behavior.