Skip to content

Remove obsolete Node.js compatibility guards #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minggangw merged 1 commit into from
Oct 16, 2026
Merged

Remove obsolete Node.js compatibility guards #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions test/test-async-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,14 +258,6 @@ describe('Client async functionality', function () {
});

it('should handle zero and negative timeouts', async function () {
// Skip this test on Node.js < 18.20.0: AbortSignal.timeout() was added in 17.3.0,
// but support for zero timeout values was only fixed in
// 18.20.0 (prior versions throw RangeError for AbortSignal.timeout(0))
const [major, minor] = process.versions.node.split('.').map(Number);
if (major < 18 || (major === 18 && minor < 20)) {
this.skip();
}

const request = { a: BigInt(1), b: BigInt(1) };

try {
Expand Down
3 changes: 0 additions & 3 deletions test/test-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,6 @@ describe('Client coverage testing', function () {
});

it('sendRequestAsync handles manual abort', async function () {
if (typeof AbortController === 'undefined') this.skip();

const client = new Client(
mockHandle,
mockNodeHandle,
Expand All @@ -334,7 +332,6 @@ describe('Client coverage testing', function () {
await promise;
assert.fail('Should have aborted');
} catch (err) {
// Name might vary depending on polyfill or native
assert.ok(err.name === 'AbortError', 'Error name ' + err.name);
}
});
Expand Down
Loading