Skip to content

Replace rimraf cleanup and remove the redundant tree-kill declaration #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minggangw merged 1 commit into from
Oct 16, 2026
Merged

Replace rimraf cleanup and remove the redundant tree-kill declaration #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"generate-messages-idl": "node scripts/generate_messages.cjs --idl",
"generate-messages:dev": "node scripts/generate_messages.cjs --debug",
"generate-tsd-messages": "node scripts/generate_tsd.cjs",
"clean": "node-gyp clean && npx rimraf ./generated",
"clean": "node-gyp clean && node -e \"require('node:fs').rmSync('./generated', { recursive: true, force: true, maxRetries: 3 })\"",
"install": "node scripts/install.cjs",
"postinstall": "npm run generate-messages",
"docs": "make -C tools/jsdoc",
Expand Down Expand Up @@ -111,9 +111,7 @@
"lint-staged": "^17.0.0",
"mocha": "^12.0.0",
"prebuildify": "^6.0.1",
"rimraf": "^6.0.1",
"sinon": "^22.0.0",
"tree-kill": "^1.2.2",
"tsd": "^0.33.0",
"tsdown": "^0.23.1",
"typescript": "^6.0.3"
Expand Down
13 changes: 2 additions & 11 deletions test/test-message-generation-bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import childProcess from 'child_process';
import fs from 'fs';
import os from 'os';
import path from 'path';
import * as rimraf from 'rimraf';
import rclnodejs from '../index.js';

const GEN_FOLDER = 'generated';
Expand Down Expand Up @@ -130,21 +129,13 @@ suite('rclnodejs generate-messages binary-script tests', function () {

let generatedFolderPath = createGeneratedFolderPath(this.tmpPkg);
if (fs.existsSync(generatedFolderPath)) {
if (getNodeVersionInfo()[0] === 10) {
rimraf.sync(generatedFolderPath);
} else {
fs.rmSync(generatedFolderPath, { recursive: true });
}
fs.rmSync(generatedFolderPath, { recursive: true });
}
});

after(function () {
// recursively remove test package folder
if (getNodeVersionInfo()[0] === 10) {
rimraf.sync(this.tmpPkg);
} else {
fs.rmSync(this.tmpPkg, { recursive: true });
}
fs.rmSync(this.tmpPkg, { recursive: true });
});

it('test generate-ros-messages script installation', function (done) {
Expand Down
Loading