Refresh Electron prebuild target and demo apps#1492
Merged
minggangw merged 1 commit intoRobotWebTools:developfrom Apr 20, 2026
Merged
Refresh Electron prebuild target and demo apps#1492minggangw merged 1 commit intoRobotWebTools:developfrom
minggangw merged 1 commit intoRobotWebTools:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Electron versions used for building Electron-specific prebuilt binaries and for the Electron demo applications, aligning the project with maintained Electron release lines ahead of the ROS 2 Lyrical window.
Changes:
- Bump the
prebuild:electrontarget fromelectron@23.0.0toelectron@34.0.0. - Update all
electron_demo/*apps fromelectron@^40.1.0toelectron@^41.0.0.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates the Electron runtime target used when generating Electron prebuilds. |
| electron_demo/turtle_tf2/package.json | Bumps demo app Electron dependency to a newer supported major line. |
| electron_demo/topics/package.json | Bumps demo app Electron dependency to a newer supported major line. |
| electron_demo/manipulator/package.json | Bumps demo app Electron dependency to a newer supported major line. |
| electron_demo/car/package.json | Bumps demo app Electron dependency to a newer supported major line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prebuild:electronscript was still pinned toelectron@23.0.0, an EOL release from Dec 2022 that bundles Node 18.12. Bump it toelectron@34.0.0, the most recent line whose bundled Node (20.18.1) matches the major version of ourengines.node >= 20.20.2floor.The four
electron_demo/*apps were pinned to^40.1.0, which goes EOL on Jun 30, 2026. Bump them to^41.0.0(supported through Aug 25, 2026) so demos stay on a maintained, security-patched Electron line ahead of the Lyrical GA window.N-API ABI stability means binaries built against Electron 34 continue to load cleanly in 41+, so the prebuild-target / demo-target split is intentional and safe.
Fix: #1458