style(ui): route CheckRuns pane CI pips through the --cx-ci-* namespace (RIG-2127) - #406
Open
rigel-mintaka wants to merge 1 commit into
Conversation
…ce (RIG-2127) T4 of the Bridge re-clothe (RIG-2111). The frozen T4 deliverable — Bridge board CI/review badges colored via `--cx-ci-*`/`--cx-review-*`, `commented` → pending, the SEA-2117 glyph form — already landed in main via the badge-clarity lane (RIG-2121/2122/2123) after T4 was written, so the board side of T4 is a no-op. Per Matt's decision, T4 is repurposed to the one residual: the RightSidebar CheckRuns pane still colored its CI pips through the generic status tokens. Re-points `.check-pip[data-status]` and `.c-verdict[data-status]` (`success`/`failure`/`pending`) from `--cx-ok`/`--cx-error`/`--cx-warn` onto `--cx-ci-pass`/`--cx-ci-fail`/`--cx-ci-pending`, so board and sidebar CI color route through one CI namespace (D3 consistency). The CI tokens currently alias the generics in `tokens.css`, so this is a zero-rendered-change semantic re-point — no visual baseline moves. Scope note: this extends T4 beyond the record's board-only wording into the right-sidebar surface, at Matt's direction; the frozen record's Plan-T4 line predates the badge lane landing and could take a follow-up amendment to stay in sync. Spec-impact: none. Refs RIG-2127 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-ux-rig-2127-checkrun.compass-eng-docs.pages.dev Deployed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainT4 of the Bridge re-clothe (RIG-2111). The frozen T4 deliverable — Bridge board CI/review badges colored via
--cx-ci-*/--cx-review-*,commented→ pending, the SEA-2117 glyph form — already landed in main via the badge-clarity lane (RIG-2121/2122/2123) after T4 was written, so the board side of T4 is a no-op. Per Matt's decision, T4 is repurposed to the one residual: the RightSidebar CheckRuns pane still colored its CI pips through the generic status tokens.Re-points
.check-pip[data-status]and.c-verdict[data-status](success/failure/pending) from--cx-ok/--cx-error/--cx-warnonto--cx-ci-pass/--cx-ci-fail/--cx-ci-pending, so board and sidebar CI color route through one CI namespace (D3 consistency). The CI tokens currently alias the generics intokens.css, so this is a zero-rendered-change semantic re-point — no visual baseline moves.Scope note: this extends T4 beyond the record's board-only wording into the right-sidebar surface, at Matt's direction; the frozen record's Plan-T4 line predates the badge lane landing and could take a follow-up amendment to stay in sync.
Spec-impact: none. Refs RIG-2127
Co-authored-by: Matt Wilkinson matt@rigel.build