docs(hooks): document the pre-push temp-worktree tool-drift hazard - #376
Open
rigel-mintaka wants to merge 1 commit into
Open
docs(hooks): document the pre-push temp-worktree tool-drift hazard#376rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
The pre-push gate runs `moon ci` inside jj-vine's throwaway hook worktree (`/tmp/jj-hooks-worktree-*`), which has the checked-out tree but no direnv activation. So `moon ci` there resolves biome/moon from the ambient system PATH instead of the devenv pins — a system biome that is not the biome.json pin (2.5.4) reformats files the pinned biome leaves clean and reds the gate falsely. Extend the `hk.pkl` header comment with the hazard, a never-`--write`-from-the-worktree warning, the interim workaround (verify in the devenv shell, push with hooks skipped, confirm GitHub CI green), and a pointer that the durable fix — propagating the repo's devenv env into the hook worktree, one fix fleet-wide — is tracked in the zireael/jj-hp lane. Comment-only; the `check = "moon ci"` step is untouched and `hk validate` passes. Spec-impact: none. Refs SEA-2006 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-sea-2006-t7-hkpkl-ga.compass-eng-docs.pages.dev Deployed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-push gate runs
moon ciinside jj-vine's throwaway hook worktree (/tmp/jj-hooks-worktree-*), which has the checked-out tree but no direnv activation. Somoon cithere resolves biome/moon from the ambient system PATH instead of the devenv pins — a system biome that is not the biome.json pin (2.5.4) reformats files the pinned biome leaves clean and reds the gate falsely.Extend the
hk.pklheader comment with the hazard, a never---write-from-the-worktree warning, the interim workaround (verify in the devenv shell, push with hooks skipped, confirm GitHub CI green), and a pointer that the durable fix — propagating the repo's devenv env into the hook worktree, one fix fleet-wide — is tracked in the zireael/jj-hp lane. Comment-only; thecheck = "moon ci"step is untouched andhk validatepasses.Spec-impact: none. Refs SEA-2006
Co-authored-by: Matt Wilkinson matt@rigel.build