Skip to content

fix(date-time): Reject impossible dates in DateTimeDiff with a format #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zigzagdev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(date-time): Reject impossible dates in DateTimeDiff with a format #1884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ab19b
fix: Reject impossible dates in DateTimeDiff with a format
zigzagdev Oct 25, 2026
30f0472
test: Cover impossible dates in DateTimeDiff with a format
zigzagdev Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Validators/DateTimeDiff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ private function createDateTimeObject(mixed $input): DateTimeInterface|null
}
}

if (!$this->isDateTime($this->format, (string) $input)) {
return null;
}

$format = $this->getExceptionalFormats()[$this->format] ?? $this->format;
$dateTime = DateTimeImmutable::createFromFormat($format, (string) $input);
if ($dateTime === false) {
Expand Down
13 changes: 13 additions & 0 deletions tests/unit/Validators/DateTimeDiffTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ public static function providerForValidInput(): array
'years + DateTime' => [new DateTimeDiff('years', Stub::pass(1)), new DateTimeImmutable()],
'years + string' => [new DateTimeDiff('years', Stub::pass(1)), '2020-01-01'],
'years + string + format' => [new DateTimeDiff('years', Stub::pass(1), 'Y-m-d'), '2020-01-01'],
'years + leap day + format' => [new DateTimeDiff('years', Stub::pass(1), 'Y-m-d'), '2024-02-29'],
'years + string + exceptional format' => [
new DateTimeDiff('years', Stub::pass(1), 'c'),
'2020-01-01T00:00:00+00:00',
],
'years + string + format + now' => [
new DateTimeDiff('years', Stub::pass(1), 'Y-m-d', new DateTimeImmutable()),
'2020-01-01',
Expand Down Expand Up @@ -80,6 +85,14 @@ public static function providerForInvalidInput(): array
new DateTimeDiff('years', Stub::fail(1), 'Y-m-d'),
'invalid date',
],
'impossible date, with passing rule' => [
new DateTimeDiff('years', Stub::pass(1), 'Y-m-d'),
'2023-02-30',
],
'impossible date in exceptional format, with passing rule' => [
new DateTimeDiff('years', Stub::pass(1), 'c'),
'2023-02-30T00:00:00+00:00',
],
] + array_map(
static fn(array $args): array => [new DateTimeDiff('years', Stub::fail(1)), new DateTimeImmutable()],
iterator_to_array(self::providerForNonScalarValues()),
Expand Down
Loading