Skip to content

Fix pathtracer double-counting ambient light #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanatwork wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pathtracer double-counting ambient light #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tutorials/pathtracer/pathtracer_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1564,6 +1564,8 @@ Vec3fa renderPixelFunction(const TutorialData& data, float x, float y, RandomSam
for (unsigned int i=0; i<data.ispc_scene->numLights; i++)
{
const Light* l = data.ispc_scene->lights[i];
/* ambient light is already accounted for when rays escape */
if (l->type == LIGHT_AMBIENT) continue;
//Light_SampleRes ls = l->sample(l,dg,RandomSampler_get2D(sampler));
Light_SampleRes ls = Lights_sample(l,dg,RandomSampler_get2D(sampler));
if (ls.pdf <= 0.0f) continue;
Expand Down
2 changes: 2 additions & 0 deletions tutorials/pathtracer/pathtracer_device.ispc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,6 +1562,8 @@ Vec3f renderPixelFunction(const uniform TutorialData& data, float x, float y, Ra
for (uniform unsigned int i=0; i<data.ispc_scene->numLights; i++)
{
const uniform Light* uniform l = data.ispc_scene->lights[i];
/* ambient light is already accounted for when rays escape */
if (l->type == LIGHT_AMBIENT) continue;
//Light_SampleRes ls = l->sample(l,dg,RandomSampler_get2D(sampler));
Light_SampleRes ls = Lights_sample(l,dg,RandomSampler_get2D(sampler));
if (ls.pdf <= 0.0f) continue;
Expand Down
Loading