Added an accessor for integer64#7724
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7724 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 87 87
Lines 17123 17040 -83
=======================================
- Hits 16959 16877 -82
+ Misses 164 163 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I guess there might have been some misunderstanding here. Adding the definition from #7618 is not what the issue is about, but instead it should be about carefully iterating over every use of |
|
@ben-schwen For clarification, this issue also requires replacing uses of |
Exactly! |
Closes #7618
Previously, the
integer64type was used using direct casts that lead to inconsistency, such as:(const int64_t *)DATAPTR_RO(x)and(int64_t *)DATAPTR(x)or(const int64_t *)REAL(x)and(int64_t *)REAL(x)This was due to R not natively supporting 64-bit integer type, requiring its definition in the {bit64} pacakge. The direct casting leads to styling differences.
To fix this, we added an accessor for
integer64type in thesrc/data.table.h.Now the datatype is accessible using
INTEGER64_RO/INTEGER64to cast to cast from theREAL_ROandREALaccessors.We also submitted this in the {bit64} repository for future implementation, they will be looking into this after their next release #312.
Also, per this comment on our original issue we did not include new tests to
inst/tests/test.Rraw, as our PR adds no new logic, as well as updated theNEWS.mdfile.