fix: Fix bug that could cause focus to be lost when deleting a block#9779
Open
fix: Fix bug that could cause focus to be lost when deleting a block#9779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
This PR fixes a bug that could cause focus to be lost when deleting a block. Blocks attempt to focus a neighbor upon deletion, but because the neighbor was being found mid-dispose, blocks had not yet marked their children as disposing, so in some cases a child block was found as the new focus position, which caused focus to be lost. Moving this to after
super.dispose()fixes the issue by ensuring that the block and its children are all marked as disposing.