Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR fixes a bug where the DropDownDiv and WidgetDiv would be misaligned when the injection div (or whatever element
common.setParentContainer()was called with) has a border. This surfaced in Scratch, which has a 1px border on the injection div, which caused field editors to be slightly offset from the field. This is trivially reproducible in core by setting e.g. a 20px border on the injection div in the playground and clicking an editable field or opening a dropdown or contextual menu. This change was LLM-assisted because CSS is cursed; I reviewed the implementation.jsdomalso had a bug that defaulted elements to 16px border which was fixed in the latest version, so I bumped that as well to avoid errant test failures.Reason for Changes
Things should appear in the correct place.