chore: migrate HawkEye to v7 - #300
Conversation
Signed-off-by: tison <wander4096@gmail.com>
fredespi
left a comment
fredespi
left a comment
There was a problem hiding this comment.
I verified the migrated HawkEye v7 configuration directly against the repository: all 214 selected files pass cleanly. One CI reproducibility issue should be fixed before merge: the installer action is pinned, but the HawkEye version it resolves is not.
| rm -f "${tarball}" | ||
| uses: taiki-e/install-action@82cd3e7658a6f96c86c0234aeeda1748937cb0a1 # v2.85.13 | ||
| with: | ||
| tool: hawkeye |
There was a problem hiding this comment.
Please pin the tool version here, for example hawkeye@7.0.0. At this pinned install-action revision HawkEye has no action manifest, so tool: hawkeye becomes an unversioned cargo-binstall fallback and resolves the latest release on every run. That means a future major release can break this v7-only config or silently change what the license gate enforces, despite the action SHA being pinned. It also drops the explicit tool-version/checksum reproducibility that the previous workflow intentionally provided.
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
This comment was marked as low quality.
This comment was marked as low quality.
|
Emmm ... |
|
I'll handle this manually. |
Signed-off-by: tison <wander4096@gmail.com>
|
@fredespi You may trigger the CI now. |
|
Re-reviewed at |
2 participants
Summary
migrate the HawkEye configuration to v7 and use its built-in Markdown style
replace the pinned v6 binary download/cache path with a SHA-pinned install action that installs the latest HawkEye release
validate 214 files with 0 changes, 0 conflicts, and 0 unsupported files
preserve both the cryptographic commit signature and DCO sign-off
If this PR fixes a bug, searched
tests/e2e-cucumber/expectations.tomlfor the fixed ticket ID and removed/narrowed any now-stale xfail rows.