feat(install): add --yes flag for non-interactive SDK installation (EAI-7956) - #273
Open
r0x0r wants to merge 1 commit into
Open
feat(install): add --yes flag for non-interactive SDK installation (EAI-7956)#273r0x0r wants to merge 1 commit into
r0x0r wants to merge 1 commit into
Conversation
r0x0r
force-pushed
the
rocm-latest-version
branch
from
August 18, 2026 10:15
2481c80 to
f268078
Compare
r0x0r
force-pushed
the
rocm-latest-version
branch
2 times, most recently
from
August 18, 2026 12:26
fb04114 to
d0c3555
Compare
…d update tests Signed-off-by: Roman Sirokov <roman.sirokov@amd.com>
r0x0r
force-pushed
the
rocm-latest-version
branch
from
August 21, 2026 12:31
d0c3555 to
b065fc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--yesflag torocm install sdkso an SDK install can proceed non-interactively, and makes overwriting an existing managed ROCm SDK an explicit, opt-in action.--yesis passed, instead of silently clobbering the active runtime.--yesalso continues to approve required system-package installs (e.g. OpenMPI for vLLM) without asking.Implementation notes
therock::install_sdknow returnsSdkInstallResult { output, mutated }; callers finalize the runtime (finalize_successful_sdk_install) only when the install actually mutated state, rather than keying offdry_runalone.yesargument is threaded through theinstalldispatch, the dry-run renderer, and the runtime-update path.Testing
cargo test --workspace/cargo clippy --workspace --all-targets -- -D warnings.tests/e2e-cucumber/features/runtime_setup.featurecovering the user-observable behavior:runtime-install-sdk-overwrite-requires-yes(@requires-gpu) — reinstall without--yesis refused with an error explaining--yesis required. The refusal bails before any download, but the precondition (an active runtime) needs a GPU, so it runs on the GPU lane.runtime-install-sdk-overwrite-with-yes(@requires-gpu @nightly) — with--yesthe reinstall overwrites and the runtime stays registered/active. Nightly-gated because it performs a real second SDK install.Both scenarios are GPU/nightly-gated and therefore exercised on the self-hosted GPU and nightly lanes, not the default PR lane.