[Feature] Add kernel-accessible ImageBatchVarShapeWrapper#154
Open
zacharyvincze wants to merge 7 commits into
Open
[Feature] Add kernel-accessible ImageBatchVarShapeWrapper#154zacharyvincze wants to merge 7 commits into
zacharyvincze wants to merge 7 commits into
Conversation
zacharyvincze
changed the title
Contributor
Author
|
Build failing because of ImageWrapper -> TensorWrapper. Known issue, will have to apply fix manually. |
This was referenced Jun 10, 2026
…rted ImageBatchVarShape data
…ious ImageWrapper
zacharyvincze
force-pushed
the
zv/feature/image-wrapper-varshape
branch
from
July 13, 2026 14:12
bce3786 to
49dd229
Compare
Contributor
Author
|
Moving out of draft as I've rebased to ensure the commit history is clean against develop. |
zacharyvincze
marked this pull request as ready for review
July 13, 2026 14:13
The LINEAR and CUBIC fast-path bounds checks in InterpolationWrapper::at called m_desc.width()/height() with the default batch index (n=0), so for a variable-shape batch every image was tested against image 0's dimensions. Narrower images then took the no-border at_inbounds path past their own right/bottom edge instead of clamping (REPLICATE), producing wrong edge pixels. Pass the batch index n so each image is bounded by its own width(n)/height(n). Uniform TensorWrapper ignores n, so the uniform path is unchanged. NEAREST was unaffected (no fast path). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
ImageBatchVarShapecontainer.ImageWrappertoTensorWrapperfor clarity purposes.TensorWrappershould be used to wrapTensor, whileImageBatchVarShapeWrapperwraps its respectiveImageBatchVarShape.TensorWrapperorImageBatchVarShapeWrapper. Reduces potential code duplication.Notes