Conversation
Add the experimental SM90 MXFP8 x MXFP4 grouped GEMM implemented in Triton with WGMMA, together with its SM90 PTX/numeric probe and an end-to-end prep/compute benchmark. The kernel is gated and intentionally not registered as a provider until SM90 numeric/PTX/sanitizer checks pass. Signed-off-by: Bignonia7 <Bignonia7@users.noreply.github.com>
Bignonia7
requested review from
Flink-ddd and
inaniloquentee
as code owners
September 20, 2026 09:27
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
KJLdefeated
self-requested a review
September 21, 2026 04:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the experimental SM90 MXFP8 x MXFP4 grouped GEMM implemented in Triton with WGMMA, together with its SM90 PTX/numeric probe and an end-to-end prep/compute benchmark. The kernel is gated and intentionally not registered as a provider until SM90 numeric/PTX/sanitizer checks pass.
Files
rl_engine/moe/triton_grouped_gemm_wgmma.py— SM90 MXFP8×MXFP4 routed-expert grouped GEMM (Triton WGMMA) with GPU-side scheduling: per-expert element offsets + exact M-tile prefix; a fixed program count traverses the prefix without host-side device reads; recursive GPU scan for large E (no CPU fallback); checked entry points synchronize to report invalid content;validate_contents=Falseonly for caller-guaranteed-valid offsets/E8M0 codes. Not registered as a provider until SM90 numeric/PTX/sanitizer gates pass.scripts/probe_p5_triton_wgmma.py— SM90 gate: assertswgmma.mma_asyncis present in the compiled PTX and compares GPU output against the serial FP32 oracle. Deliberately separate from provider registration.benchmarks/benchmark_triton_grouped_wgmma.py— experimental SM90 prep/compute end-to-end timing; run the probe and sanitizers first; timing success is not a numeric gate; all inputs stay packed with explicit GPU/host latency labels.