Conversation
- Changes commands to use the new fabric permission API - Changes networking API to use the new fabric permission API - Removes dependency on lucko's API - Bump Fabric API to 0.158.0 & Minecraft to 26.2
PotatoPresident
requested changes
Sep 29, 2026
PotatoPresident
left a comment
PotatoPresident
left a comment
Member
There was a problem hiding this comment.
Might be worth mentioning in the docs that luckperms (and potentially other permission systems) covert the namespaced permissions (ledger:x) back to the legacy ledger.x format
|
|
||
| ## Versions | ||
|
|
||
| All packets are correct for Ledger Networking v3, which is included in Ledger 1.3.0 and later. |
Member
There was a problem hiding this comment.
This doesn't really add anything
|
|
||
| Each packet also requires the permissions that the corresponding command does, but note that this does have fallback to permission level. | ||
|
|
||
| ### Permissions prior to version 1.3.24 |
Member
There was a problem hiding this comment.
This section is unnecessary. Users can just look at old versions of docs
| import net.minecraft.server.permissions.PermissionLevel | ||
| import java.util.function.Predicate | ||
|
|
||
| private const val NAMESPACE = "ledger" |
Member
There was a problem hiding this comment.
Use the mod id constant in main Ledger object
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Fabric Permissions API v1.
New permissions for commands:
ledger:command/<command_full_name>ledger:networking, there remains no fallback (this must be explicitly given instead of via permission level)Closes #377