Repository navigation
Fix expression caching within polling attempts - #1214
Open
GtechGovind wants to merge 1 commit into
Open
GtechGovind wants to merge 1 commit into
GtechGovind wants to merge 1 commit into
Conversation
GtechGovind
marked this pull request as ready for review
October 17, 2026 06:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #360.
I reproduced a polling failure where the matcher result and diagnostic observed different values from the same expression. The expression could be evaluated more than once during a single polling attempt.
I added a fresh expression cache for each polling attempt across synchronous, async, and require expectations. Matchers reuse a value within an attempt, while subsequent attempts still observe changes. The async-to-synchronous conversion already materializes its expression once, so I left that path unchanged.
I added regressions for changing expressions, async matchers that evaluate twice, returned require values, and continuous always/never polling, and documented the caching boundary.
Validation:
git diff --checkpassed.Installed Xcode required command-only deployment-target overrides (macOS 12 and iOS 15); I did not change the project's supported versions. Other platforms and the repository's CI toolchain matrix remain for CI.