Skip to content

Attempt to fix AMD 1.10 conj#64

Open
kshyatt wants to merge 2 commits into
mainfrom
ksh/fixamd
Open

Attempt to fix AMD 1.10 conj#64
kshyatt wants to merge 2 commits into
mainfrom
ksh/fixamd

Conversation

@kshyatt

@kshyatt kshyatt commented Jun 16, 2026

Copy link
Copy Markdown
Member

checked that 1.11 works with this. Happy for stylistic fixes -- it seems on 1.10 and AMD compilation of conj doesn't work but creating a custom f_conj does, mysterious but ok.

@kshyatt kshyatt requested a review from lkdvos June 16, 2026 10:01
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

Your PR no longer requires formatting changes. Thank you for your contribution!

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
ext/StridedGPUArraysExt.jl 54.05% <100.00%> (+4.80%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos

lkdvos commented Jun 16, 2026

Copy link
Copy Markdown
Member

Is this something we should report to AMDGPU.jl though? It might be reasonable to just give them a MWE with a kernel that uses conj?

@kshyatt

kshyatt commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

I already opened an issue there JuliaGPU/AMDGPU.jl#931

@lkdvos

lkdvos commented Jun 16, 2026

Copy link
Copy Markdown
Member

Should we just wait and see what the verdict is there? In a perfect world this is just fixed upstream and we don't even have to include this :)

@kshyatt

kshyatt commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Yeah, I don't know how long it's going to take for someone who knows the AMD compiler better than I to take a look, though.

@kshyatt

kshyatt commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

In the meantime people can Pkg.dev this branch and keep making progress I guess

@lkdvos

lkdvos commented Jun 16, 2026

Copy link
Copy Markdown
Member

Or use Julia 1.11+?

@kshyatt

kshyatt commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

IDK if anyone is stuck on 1.10 for whatever reason 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants