Skip to content

[codex] Improve manual review notification cards#16

Merged
Pigbibi merged 1 commit into
mainfrom
codex/manual-review-notification-cards
Jun 6, 2026
Merged

[codex] Improve manual review notification cards#16
Pigbibi merged 1 commit into
mainfrom
codex/manual-review-notification-cards

Conversation

@Pigbibi
Copy link
Copy Markdown
Contributor

@Pigbibi Pigbibi commented Jun 6, 2026

Summary

  • format manual-review notifications as evidence cards for TACO and panic reversal signals
  • preserve key component evidence in market_regime_control compact signals so unified notifications can include numbers
  • add regression coverage for card content and execution-boundary wording

Historical checks

  • TQQQ 2020-03-19: standalone panic_reversal notifies, full market_regime_control is macro risk_off and vetoes the opportunity
  • TQQQ 2025-04-09: standalone panic_reversal notifies, full market_regime_control is macro risk_reduced and vetoes the opportunity
  • TQQQ 2020-03-02 / 2025-04-07: no panic reversal opportunity; macro watch/risk_off context only
  • SOXL remains notification-only; full market_regime_control stays defensive when macro stress is active

Validation

  • pytest -q
  • ruff check .

Runtime boundary

No trading or allocation behavior changes. The cards explicitly say notify-only, no broker orders, and no allocation mutation.

@Pigbibi Pigbibi merged commit 7f0ad06 into main Jun 6, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/manual-review-notification-cards branch June 6, 2026 18:26
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a90124fb32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1045 to +1046
f"仲裁:{plugin} = {route};"
f"{'crisis/macro 未 veto' if not vetoes else '存在 veto:' + _message_join(vetoes, locale)}。"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid claiming veto checks ran for standalone plugins

When this formatter is used for standalone taco_rebound_shadow or panic_reversal_shadow runs, there is no market-regime arbiter or position_control.vetoes, so an empty vetoes tuple means “not checked”, not “crisis/macro did not veto”. The new manual-review card therefore gives a false risk-control assurance for direct notification mounts; only market_regime_control payloads can make this claim.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant