Skip to content

[codex] Route runtime errors to main bot#71

Merged
Pigbibi merged 1 commit into
mainfrom
codex/runtime-errors-main-bot-strategy-plugin-alerts
Jun 4, 2026
Merged

[codex] Route runtime errors to main bot#71
Pigbibi merged 1 commit into
mainfrom
codex/runtime-errors-main-bot-strategy-plugin-alerts

Conversation

@Pigbibi
Copy link
Copy Markdown
Contributor

@Pigbibi Pigbibi commented Jun 4, 2026

Summary

  • send runtime failure notifications only to the platform main Telegram bot
  • rename strategy plugin alert runtime settings to STRATEGY_PLUGIN_ALERT
  • sync Cloud Run env workflow to publish new names and remove old CRISIS_ALERT plugin envs
  • pin quant-platform-kit to 3b6a0a9bedde72773e188041e0dc48516b38aadc

Validation

  • env PYTHONPATH=.:../QuantPlatformKit/src:../UsEquityStrategies/src /tmp/codex-alert-test-venv/bin/python -m pytest -q tests/test_request_handling.py tests/test_runtime_config_support.py tests/test_sync_cloud_run_env_workflow.py
  • env PYTHONPATH=.:../QuantPlatformKit/src:../UsEquityStrategies/src /tmp/codex-alert-test-venv/bin/python -m pytest -q tests/test_rebalance_service.py

@Pigbibi Pigbibi merged commit a7c0787 into main Jun 4, 2026
1 check failed
@Pigbibi Pigbibi deleted the codex/runtime-errors-main-bot-strategy-plugin-alerts branch June 4, 2026 05:04
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c11685f36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

CRISIS_ALERT_TELEGRAM_PARSE_MODE: ${{ vars.CRISIS_ALERT_TELEGRAM_PARSE_MODE }}
CRISIS_ALERT_TELEGRAM_DISABLE_WEB_PAGE_PREVIEW: ${{ vars.CRISIS_ALERT_TELEGRAM_DISABLE_WEB_PAGE_PREVIEW }}
CRISIS_ALERT_TELEGRAM_BODY_MAX_CHARS: ${{ vars.CRISIS_ALERT_TELEGRAM_BODY_MAX_CHARS }}
STRATEGY_PLUGIN_ALERT_CHANNELS: ${{ vars.STRATEGY_PLUGIN_ALERT_CHANNELS }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve old alert vars during the rename

When this workflow first runs after the rename, installations that still have the existing CRISIS_ALERT_* GitHub variables/secrets but have not manually created the new STRATEGY_PLUGIN_ALERT_* names will resolve these new env entries as empty; the sync step then removes the old CRISIS_ALERT_* Cloud Run keys, and runtime_config_support.py only reads the new names, so strategy plugin alert recipients/tokens are silently cleared. Please either fall back to the old variable names while syncing/loading settings or add a migration path before removing the old Cloud Run envs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant