Skip to content

Use upgraded crypto live pool profile#57

Merged
Pigbibi merged 1 commit into
mainfrom
codex/upgrade-crypto-live-pool-namespace
Jun 3, 2026
Merged

Use upgraded crypto live pool profile#57
Pigbibi merged 1 commit into
mainfrom
codex/upgrade-crypto-live-pool-namespace

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary:

  • Switch Binance runtime defaults to crypto_live_pool_rotation and CRYPTO_LIVE_POOL_ROTATION_LIVE_POOL.
  • Update fixtures, notifications, workflow defaults, runtime/report tests, and docs to the new profile and source namespace.
  • Remove TREND_POOL_* external configuration aliases; only STRATEGY_ARTIFACT_* settings are read for artifacts.

Tests:

  • timeout 120 env PYTHONPATH=/home/ubuntu/Projects/BinancePlatform:/home/ubuntu/Projects/CryptoStrategies/src:/home/ubuntu/Projects/QuantPlatformKit/src /usr/bin/python3 -m unittest tests.test_strategy_runtime tests.test_strategy_loader tests.test_runtime_config_support tests.test_trend_pool_loading tests.test_runtime_support tests.test_cycle_service tests.test_main_runtime_error_notification -v
  • timeout 120 bash tests/test_runtime_workflow_shared_config.sh
  • Result: OK.

@Pigbibi Pigbibi merged commit c096293 into main Jun 3, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/upgrade-crypto-live-pool-namespace branch June 3, 2026 12:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d250cd8fa3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread strategy_registry.py


DEFAULT_STRATEGY_PROFILE = "crypto_leader_rotation"
DEFAULT_STRATEGY_PROFILE = "crypto_live_pool_rotation"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the pinned strategy package before changing the default

requirements-lock.txt:2 and requirements.txt:2 still install crypto-strategies@v0.4.7; I checked that tag's catalog/runtime adapter and it only registers crypto_leader_rotation. When the GitHub workflow or any live run relies on the default profile, resolve_strategy_definition(None) now selects crypto_live_pool_rotation, which the installed package cannot resolve, so the runtime will fail before the cycle starts. Please bump the dependency to a version that contains crypto_live_pool_rotation before making it the default.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant