docs: split bilingual open-source readmes#52
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8b79f057b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `BINANCE_API_SECRET` | Binance API secret | | ||
| | `TG_TOKEN` | Telegram bot token | | ||
| | `GLOBAL_TELEGRAM_CHAT_ID` | Telegram chat ID for alerts. | | ||
| Configure GitHub Actions secrets/variables for Binance credentials, runtime settings, notifications, and strategy source. Run the workflow manually in dry-run mode first, review logs/artifacts, then enable the scheduled workflow only after credentials and risk controls are verified. |
There was a problem hiding this comment.
This line tells operators to manually run the GitHub Actions workflow in dry-run mode, but the inspected Runtime workflow only exposes validate_only in .github/workflows/main.yml, which exits after GCP/Firestore auth, and the live path constructs ExecutionRuntime(dry_run=False) in runtime_config_support.py. For an operator following the README before enabling schedules, there is no workflow dry-run to review orders/artifacts; dispatching without validate_only runs main.py against Binance credentials, so the safe pre-live instruction is misleading and should point to the actual replay command or add a workflow dry-run toggle.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation