Skip to content

Rename mle to mle_intro so lecture names are unique across the published sites - #857

Merged
mmcky merged 1 commit into
mainfrom
rename-mle
Oct 9, 2026
Merged

mmcky merged 1 commit into
mainfrom
rename-mle

Conversation

@mmcky

@mmcky mmcky commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Part of QuantEcon/project-monorepo#76. QuantEcon/lecture-python.myst publishes a different lecture as mle, and the lectures monorepo needs every lecture name to be unique across the published sites. QuantEcon/project-monorepo#75 ruled that the intro side takes an _intro suffix.

What this changes

  • lectures/mle.md is renamed to lectures/mle_intro.md, and its _toc.yml entry follows it.
  • lectures/_config.yml gains mle.md: mle_intro.md under rediraffe_redirects, so the old address redirects to the new one.
  • Five links to it are updated, in fitting_distributions (2) and wealth_tax (3). No other series links to intro's mle by name; I checked all six.
  • Checked on the branch:
    • the redirect's old file is gone and its new file exists;
    • every _toc.yml entry has a file;
    • no {doc} link points at a missing file.

The translation hold is cleared: action-translation v0.29.4 (2026-10-09) carries QuantEcon/action-translation#291, and v0, which sync-translations-zh-cn.yml runs, now points at it. This PR stays a draft until the one before it has merged and this one is rebased.

🤖 Generated with Claude Code

@netlify

netlify Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 8b6fa69
🔍 Latest deploy log https://app.netlify.com/projects/taupe-gaufre-c4e660/deploys/6ac87c07298c6d0009045e05
😎 Deploy Preview https://deploy-preview-857--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mmcky

mmcky commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

The red checks are expected.

What fails: the HTML build stops on one warning and nothing else: (broken) mle.html redirects to mle_intro.html but _build/html/mle.html already exists!.

Why: CI restores the build cache that cache.yml built from main. That cache still holds the old page, and rediraffe overwrites only the redirect pages it wrote itself. The other builds pass.

How it lands: each of the three intro PRs stays red until it is merged. After each merge:

  1. Run cache.yml on main.
  2. Push no publish* tag until that run is green.
  3. Then rebase the next PR.

This is on top of the hold for QuantEcon/action-translation#291.

QuantEcon/lecture-python.myst publishes a different lecture as mle, and
the lectures monorepo needs every name to be unique across the published
sites; the intro side takes the _intro suffix, as ruled on
QuantEcon/project-monorepo#75. The old address redirects to the new one
through a rediraffe_redirects entry. Part of QuantEcon/project-monorepo#76.
@mmcky
mmcky marked this pull request as ready for review October 9, 2026 05:38
Copilot AI balanced review requested due to automatic review settings October 9, 2026 05:38
@mmcky
mmcky merged commit 97edff6 into main Oct 9, 2026
6 of 8 checks passed
@mmcky
mmcky deleted the rename-mle branch October 9, 2026 05:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The rename is complete and internally consistent—all five cross-references, the TOC entry, and the rediraffe redirect are correctly updated with no stale references remaining.

0 open findings

What changed in this PR

This PR renames the introductory mle lecture to mle_intro so that lecture names are unique across QuantEcon's published sites (the lecture-python.myst series already publishes a different mle lecture). It is part of a coordinated series of three intro renames (#855 lake_model, #856 lln_clt, #857 mle) tracked under QuantEcon/project-monorepo#76. The change is purely organizational—content is moved, not modified—and preserves the old URL via a rediraffe redirect.

Changes:

  • Rename lectures/mle.md → lectures/mle_intro.md and update its _toc.yml entry.
  • Add mle.md: mle_intro.md under rediraffe_redirects in _config.yml so the old address redirects.
  • Update all 5 {doc} cross-references (2 in fitting_distributions.md, 3 in wealth_tax.md).
File Description
lectures/​mle_intro.md Renamed from mle.md; content unchanged, internal {ref}/label anchors are file-independent and remain valid
lectures/​_toc.yml TOC entry updated from mle to mle_intro
lectures/​_config.yml Adds rediraffe redirect mle.md: mle_intro.md, grouped with sibling redirects
lectures/​fitting_distributions.md Two {doc}mle`` references updated to mle_intro
lectures/​wealth_tax.md Three {doc}mle`` references updated to mle_intro (one with `<mle_intro>` link text)

I verified via a full-repository search that no stale {doc}mle``, <mle>, or `mle.md`/`mle.html` references remain, the old file is gone, the new file exists, and the `_toc.yml` entry and `_config.yml` redirect are correctly placed. The rename is complete and consistent, matching the pattern of the sibling PRs. I found no issues to flag.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants