Allow combo order quantity updates in the TradeStation brokerage model - #9843
Merged
Martin-Molinero merged 2 commits intoOct 1, 2026
Conversation
TradeStation resizes the whole spread on replace; live already skips the brokerage model on updates, so only backtests refused it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AlexCatarino
force-pushed
the
bug-9842-tradestation-combo-quantity-update
branch
from
September 29, 2026 21:15
3515d56 to
a8d7d51
Compare
Martin-Molinero
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9842.
Description
Removes the combo quantity check from
TradeStationBrokerageModel.CanUpdateOrder. TradeStation resizes the whole spread on replace, and live trading skips the brokerage model on updates, so only backtests refused it.Related Issue
#9842, QuantConnect/Lean.Brokerages.TradeStation#107
Motivation and Context
Same algorithm, an AAPL call vertical x1 whose leg 0 ticket is updated to quantity 2:
UpdateSubmittedon both legs, the broker holds Buy 2 / Sell 2.NotSupported - Order type 'ComboLimit' is not supported to update quantity in the TradeStationBrokerageModel., legs stay 1 / -1.Requires Documentation Change
No.
How Has This Been Tested?
TradeStationBrokerageModelTests.CanUpdateComboOrdersnow expects the quantity updates to be allowed.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>🤖 Generated with Claude Code