feat(clusters): add dry runs to the list of cluster deployments - #2991
Conversation
|
View your CI Pipeline Execution ↗ for commit a2e261f
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #2991 +/- ##
===========================================
- Coverage 50.47% 50.31% -0.17%
===========================================
Files 1373 1352 -21
Lines 29738 29344 -394
Branches 8781 8659 -122
===========================================
- Hits 15011 14764 -247
+ Misses 12248 12149 -99
+ Partials 2479 2431 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new test does not verify that non-dry-run deployments omit the badge.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds a “Dry run” badge to cluster deployment history using the updated API type.
Changes:
- Upgrades
qovery-typescript-axiosto1.1.981. - Renders the badge when
is_dry_runis true. - Adds test data and positive badge coverage.
| File | Description |
|---|---|
package.json |
Updates the API client dependency. |
yarn.lock |
Locks the new dependency version and checksum. |
cluster-deployment-list.tsx |
Displays the dry-run badge. |
cluster-deployment-list.spec.tsx |
Adds dry-run fixture data and test coverage. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic


Summary
Issue: N/A
is_dry_runfield.qovery-typescript-axios1.1.981, which provides the typed field.Screenshots / Recordings
Testing
yarn nx test domains-clusters-feature --testPathPatterns=cluster-deployment-list.spec.tsxyarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release