Skip to content

feat(clusters): add dry runs to the list of cluster deployments - #2991

Merged
rmnbrd merged 4 commits into
stagingfrom
feat/dry-run-deployment-history
Sep 22, 2026
Merged

rmnbrd merged 4 commits into
stagingfrom
feat/dry-run-deployment-history

Conversation

@rmnbrd

@rmnbrd rmnbrd commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Issue: N/A

  • Includes dry-run cluster deployments in deployment history.
  • Displays the existing-style neutral Dry run badge from the API is_dry_run field.
  • Uses qovery-typescript-axios 1.1.981, which provides the typed field.

Screenshots / Recordings

image

Testing

  • Changes tested locally in the relevant Console preview
  • yarn nx test domains-clusters-feature --testPathPatterns=cluster-deployment-list.spec.tsx
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@nx-cloud

nx-cloud Bot commented Sep 21, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit a2e261f

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 3s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 35s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 36s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 6s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-21 14:35:10 UTC

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.31%. Comparing base (5486a6c) to head (a2e261f).
⚠️ Report is 5 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2991      +/-   ##
===========================================
- Coverage    50.47%   50.31%   -0.17%     
===========================================
  Files         1373     1352      -21     
  Lines        29738    29344     -394     
  Branches      8781     8659     -122     
===========================================
- Hits         15011    14764     -247     
+ Misses       12248    12149      -99     
+ Partials      2479     2431      -48     
Flag Coverage Δ
unittests 50.31% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd

rmnbrd commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

UI capture using a dry-run deployment fixture. The typed SDK field renders the neutral Dry run badge alongside the successful deployment status.

Cluster deployment history row showing a successful dry run

@rmnbrd
rmnbrd marked this pull request as ready for review September 21, 2026 14:24
Copilot AI lite review requested due to automatic review settings September 21, 2026 14:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new test does not verify that non-dry-run deployments omit the badge.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds a “Dry run” badge to cluster deployment history using the updated API type.

Changes:

  • Upgrades qovery-typescript-axios to 1.1.981.
  • Renders the badge when is_dry_run is true.
  • Adds test data and positive badge coverage.
File Description
package.json Updates the API client dependency.
yarn.lock Locks the new dependency version and checksum.
cluster-deployment-list.tsx Displays the dry-run badge.
cluster-deployment-list.spec.tsx Adds dry-run fixture data and test coverage.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@rmnbrd
rmnbrd enabled auto-merge (squash) September 21, 2026 14:47
@rmnbrd
rmnbrd merged commit af5650b into staging Sep 22, 2026
8 checks passed
@rmnbrd
rmnbrd deleted the feat/dry-run-deployment-history branch September 22, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants