Fix duplicate-definition link error in _compile_module - #1
Open
cjmielke wants to merge 1 commit into
Open
Conversation
frontend_agglomerate.cpp was compiled twice: once explicitly into
obj_path, and again via witty.compile_cython's source_files=, which
was then also linked against obj_path through extra_link_args. Every
symbol in frontend_agglomerate.cpp ended up defined twice, causing a
linker error ("multiple definition of ...") on every build.
Drop the redundant source_files= entry since the object is already
linked explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend_agglomerate.cpp was compiled twice: once explicitly into
obj_path, and again via witty.compile_cython's source_files=, which
was then also linked against obj_path through extra_link_args. Every
symbol in frontend_agglomerate.cpp ended up defined twice, causing a
linker error ("multiple definition of ...") on every build.
Drops the redundant source_files= entry since the object is already
linked explicitly.