fix: GuildSchedule not being cached correctly + missing fields#3025
fix: GuildSchedule not being cached correctly + missing fields#3025Lumabots wants to merge 58 commits into
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3025/head:pr-3025
git checkout pr-3025This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3025/head |
|
Audit Logs still need to be rework (i didnt understand how it work yet) |
|
should we use use_cache_on_error, instead of only use cache ? that way we will be able to fetch first and if unavailable we will get |
Paillat-dev
left a comment
There was a problem hiding this comment.
If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.
Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
when anonymous pr will be merged i'll edit it to make it work |
Co-authored-by: Copilot <copilot@github.com>
Paillat-dev
left a comment
There was a problem hiding this comment.
Also please use from typing_extensions import deprecated and not typing_extensions.deprecated throughout
| _enum_transformer(enums.NotificationLevel), | ||
| ), | ||
| "entity_metadata": (None, _transform_entity_metadata), | ||
| "location": (None, _transform_entity_metadata), |
There was a problem hiding this comment.
Still confused, location isn't supposed to exist as a top level property on Discord's side no ? So why even do we want to set this if it's never there in the first place ? This code is a mess so I may be wrong here but I'm confused as to why we would handle something Discord doesn't send.
…-Development/pycord into on_scheduled_event_delete
Paillat-dev
left a comment
There was a problem hiding this comment.
I think you mmerged by mistake this pr with the component limits one

Summary
summary is not complete, just check the code
Added
New Enums :
ScheduledEventRecurrenceFrequency (yearly, monthly, weekly, daily)
ScheduledEventRecurrenceWeekday (monday-sunday)
ScheduledEventRecurrenceMonth (january-december)
New Classes:
ScheduledEventEntityMetadata (location)
ScheduledEventRecurrenceNWeekday Represents n-weekday entries (e.g., "1st Tuesday")
ScheduledEventRecurrenceRule: Full recurrence rule with validation
Auto-validates on to_payload() serialization
New fields Guild.create_scheduled_event():
Enforces Discord's constraints:
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.