fix merge queue breakages - #6310
Merged
Merged
Conversation
From nightly-2026-08-07 cargo no longer finds the sysroot `cargo careful`
builds for itself when running test binaries. Proc-macro crates link `libstd`
dynamically, so the `pyo3-macros` test binary can't start:
error while loading shared libraries: libstd-<hash>.so: cannot open
shared object file: No such file or directory
That aborts the job before it gets to anything else. Pin to the last nightly
where it works; revert to `@nightly` once
RalfJung/cargo-careful#55 is fixed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N96dd4VafzejRKxEuk1pU4
Two problems, both surfaced by CPython 3.14 moving to a new patch release:
* `test-wasm` points the embedded interpreter at `PYTHONPATH=/lib`, which has
never existed in the CPython checkout. It worked because `getpath` found the
build tree itself, via the `Modules/Setup.local` landmark next to the
"executable". CPython 3.14.7 removed that fallback (gh-151544), so the test
binaries now die on startup with "Fatal Python error: Failed to import
encodings module". Pass the stdlib and the WASI build directory explicitly.
* The `.nox/wasi` cache is keyed on `UV_PYTHON` ("3.14"), not on the CPython
version nox builds and then looks for, so a new patch release restores the
previous one's build and skips the build step. `cargo test` then fails
immediately with "failed to search the lib dir at PYO3_CROSS_LIB_DIR=...".
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N96dd4VafzejRKxEuk1pU4
davidhewitt
approved these changes
Aug 8, 2026
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks, this seems plausible to me, though I would prefer the extended commentary to be PR description and the inline comments to be more terse.
(IMO AI-generated code frequently leaves artifacts describing historical properties of code all over the place, and I tend to feel these just clutter thoughts rather than add value once the change has been done)
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Member
Author
|
Agree: re: AI comment style. (It was so much worse before I trimmed it 🙃). The individual commits have much more detail. |
alex
enabled auto-merge
August 8, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's two breakages: