Fix optional hypothesmith import on Python 3.14#118
Open
l46983284-cpu wants to merge 1 commit into
Open
Conversation
Catch any Exception when importing hypothesis/hypothesmith so a broken optional dependency (e.g. typing.ByteString removed on 3.14) skips the fuzz test instead of failing collection. Fixes PyCQA#113 Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3.14, an installed but incompatible
hypothesis/hypothesmithcan raiseAttributeErrorduring import (typing.ByteStringwas removed). That still failed collection of the wholetest_mccabe.pymodule.#117 already made the fuzz test optional when those packages are missing (
ImportError). This follows that pattern and treats any import-time failure the same way: sethypothesmith = Noneso the existing stub skips the optional fuzz test and the rest of the suite still runs.Test plan
python3 -m pytest -q -k 'not test_get_module_complexity' test_mccabe.py→ 14 passed, 1 skippedAttributeErroron hypothesmith/hypothesis) → guard setshypothesmith is Nonetest_get_module_complexityflake (unrelated C901 path); not part of this changeFixes #113