Repository navigation
fix: keep tab-width compensation local to each docstring - #409
Merged
weibullguy merged 1 commit intoNov 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tab-width compensation currently subtracts from the shared
wrap_summariesandwrap_descriptionsoptions. Each tab-indented docstring shrinks the widths available to later docstrings and files. With--tab-width 4 --wrap-summaries 40 --wrap-descriptions 40, thirteen identical function docstrings can even split the quote delimiters and produce invalid Python.Calculate the adjusted widths locally instead. The regression tests cover repeated docstrings and files, tab widths 4/8, preserved indentation, disabled wrapping, valid Python, and idempotence.
Validation
Read-only native-cloud validation on Python 3.12.14:
The 82 filesystem-dependent tests, full tox/pre-commit runs, and other interpreters were not run under the read-only/disk-full constraint. isort, mypy, and pydocstyle were unavailable. This is not a full-suite pass.
Prepared with OpenAI Codex assistance.