Stdlib: coerce null to empty string for typed string builtins (#18483)#18488
Closed
PurHur wants to merge 1 commit into
Closed
Stdlib: coerce null to empty string for typed string builtins (#18483)#18488PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
Restore Zend Z_PARAM_STR null→"" semantics for addslashes, stripslashes, htmlspecialchars, htmlentities, strip_tags, wordwrap, and addcslashes after #18385 regression; route VM through resolveCoercibleStringArg and JIT through lowerStrictOrCoercible. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Duplicate of merged #18486 — closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Z_PARAM_STRnull→""coercion foraddslashes,stripslashes,htmlspecialchars,htmlentities,strip_tags,wordwrap, andaddcslashesafter the Stdlib: null operand coercion parity batch (#18369–#18378) #18385 regression reintroducedrejectNullString/coerceTypedStringBuiltinArgpaths.$stringthroughInternalStrictArg::resolveCoercibleStringArg(respects callerstrict_types).lowerTypedString/rejectNullStringtolowerStrictOrCoercible.ext/standard/string.c,ext/standard/html.cVerification
Closes #18483
Made with Cursor