Stdlib: stream wrapper parity — readfile/scandir/debug_zval_dump (#18417, #18418, #18419)#18422
Closed
PurHur wants to merge 3 commits into
Closed
Stdlib: stream wrapper parity — readfile/scandir/debug_zval_dump (#18417, #18418, #18419)#18422PurHur wants to merge 3 commits into
PurHur wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…verlap Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readfile('php://output')returns Zend stdout sentinel-1(not0) viaVmFs::readfile()failed-output-handle path.scandir()/opendir()on non-directory PHP wrappers (php://filter,php://memory, …) emit Zendnot implemented+ scandir errno follow-up; sharedVmDirOpenFailureSSOT for VM + JIT (ScandirFailureJitHelper,OpendirJitHelper).debug_zval_dump()printsresource(id) of type (typename) refcount(n)for stream handles (sharedVmVarFormat+VmDebugZval::countResourceReferences()), matchingvar_dump()resource shape.php-src refs:
ext/standard/streams.c,ext/standard/dir.c,ext/standard/var.c.Test plan
./script/ci-fast.sh(inventory regen, spine 4705/4705, M5 fast gate)Closes #18417
Closes #18418
Closes #18419
Made with Cursor