Bootstrap: sync spine for BuiltinInternalDefaultValues (#18356)#18384
Merged
PurHur merged 1 commit intoJul 12, 2026
Conversation
Spine coverage sync failed after #18356 landed lib/BuiltinInternalDefaultValues.php on the vm.php path without a matching require in compiler_lib_spine_smoke. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/BuiltinInternalDefaultValues.phptocompiler_lib_spine_smoke(landed via Stdlib: ReflectionParameter internal ctor — isOptional false and getDefaultValue() missing (ext/reflection/php_reflection.c) #18356 but missing from spine).docs/bootstrap-inventory.mdso inventory counts stay in sync.Fixes red
check-selfhost-spine-coverage-sync/north-star5-verify-faststep 2 on master.Refs #18356, #1492
Test plan
Made with Cursor