Fix hash_init/update/final/copy AOT segfault (#3357)#18100
Merged
Conversation
…3357) Standalone user-script AOT crashed in hash_final/hash_copy because nested HashContextJitHelper string returns and LLVM bridge stubs were incompatible with libcrypto __compiler_hash. Mirror algo/buf on HashContext object slots, inline final/copy lowering, and re-init buffered data via __string__init before EVP digest. php-src: ext/hash/hash.c Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes AOT runtime segfault on
hash_init()/hash_update()/hash_final()/hash_copy()while preserving working basichash()AOT.hash_final/hash_copyrouted throughHashContextFinalLlvm/HashContextCopyLlvmbridge stubs and nestedHashContextJitHelperstring returns crashed in standalone user-script AOT.__hcAlgo/__hcBufonHashContextobject slots; inlinefinalLowering/copyLoweringinJitHashContext; useStringHashCryptoLlvm(__compiler_hash) for standalone AOT final path with__string__initclone before libcrypto digest.HashContextJitHelper::finalize().php-src reference:
ext/hash/hash.cVerification
Closes #3357
Supersedes broken approach in #17897 (regressed basic
hash()AOT).Made with Cursor