Support ACM certificates in supervised AWS installations - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS ALB terminates HTTPS using an ACM certificate, but
PIGDeploymentrequired a Kubernetes TLS Secret name for every ingress controller. Makeendpoint.tlsSecretNameoptional and omit the generated Ingress'ssecretNamewhen it is unset. Preserve the TLS hostname, annotations, and existing explicit-Secret behavior.Regenerate the CRD and JSON schema, document the HTTPS prerequisite, and add an ALB/ACM configuration example. Certificates and ingress controllers remain externally managed.
Validation: 155 passed, 4 cluster tests skipped; Ruff lint/format, schema generation, Kubernetes CRD admission validation with Go 1.26.0, package builds, and Terraform formatting passed. All nine required GitHub checks passed, including Kubernetes integration on 1.30.10 and 1.37.0, Terraform for all three clouds, and security checks. Independent code/type/test and documentation reviews found no blocking issues. Real ALB/TLS verification remains pending.
This targets the first release's fresh bootstrap. Existing candidate installations need an explicit CRD/bootstrap refresh: the shared-schema guard correctly refuses this schema relaxation as an automatic CRD update. Release acceptance/publication gates are unchanged.