Prevent drift in the RDS TLS parameter apply method - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh RDS PostgreSQL 16 instance reports
rds.force_ssl=1withapply_method=pending-reboot, even though the provider defaults the configured method toimmediate. The next Terraform Cloud plan therefore proposes a parameter-group update immediately after installation.Declare
pending-rebootexplicitly to match the observed AWS representation while preserving the required value of 1. New databases receive the parameter group at creation; applying a changed group to an existing database may require a reboot, so operators must verify TLS enforcement.Validation: Terraform formatting, AWS example validation, and both AWS module mock contract tests pass. The real acceptance cluster negotiated TLS 1.3 with
verify-full, rejected an unencrypted PostgreSQL connection, and passed native IRSA S3 write/read verification. Terraform Cloud also completed a real plan using this exact module source with zero additions, changes, and deletions; no further apply was needed. This is infrastructure evidence, not canonical PIG acceptance.